<html>
<head><meta charset="utf-8"><title>spawn_work turns FatalErrors into ICEs ? #66530 · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/spawn_work.20turns.20FatalErrors.20into.20ICEs.20.3F.20.2366530.html">spawn_work turns FatalErrors into ICEs ? #66530</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="183941970"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/spawn_work%20turns%20FatalErrors%20into%20ICEs%20%3F%20%2366530/near/183941970" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/spawn_work.20turns.20FatalErrors.20into.20ICEs.20.3F.20.2366530.html#183941970">(Dec 20 2019 at 14:55)</a>:</h4>
<p>Hey <span class="user-mention" data-user-id="124287">@mw</span>  I had a question for you about our spawn_work architecture</p>



<a name="183942071"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/spawn_work%20turns%20FatalErrors%20into%20ICEs%20%3F%20%2366530/near/183942071" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/spawn_work.20turns.20FatalErrors.20into.20ICEs.20.3F.20.2366530.html#183942071">(Dec 20 2019 at 14:56)</a>:</h4>
<p>the code <a href="https://github.com/rust-lang/rust/blob/6b561b4917e803c4be4ca44d8e552b680cb9e380/src/librustc_codegen_ssa/back/write.rs#L1481" target="_blank" title="https://github.com/rust-lang/rust/blob/6b561b4917e803c4be4ca44d8e552b680cb9e380/src/librustc_codegen_ssa/back/write.rs#L1481">here</a> is written effectively saying "if a worker thread gets here, it panicked; so we will panic too."</p>



<a name="183942170"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/spawn_work%20turns%20FatalErrors%20into%20ICEs%20%3F%20%2366530/near/183942170" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/spawn_work.20turns.20FatalErrors.20into.20ICEs.20.3F.20.2366530.html#183942170">(Dec 20 2019 at 14:57)</a>:</h4>
<p>but that result can come up when the worker thread hits any <code>FatalError</code>, not just panics or ICEs.</p>



<a name="183942222"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/spawn_work%20turns%20FatalErrors%20into%20ICEs%20%3F%20%2366530/near/183942222" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/spawn_work.20turns.20FatalErrors.20into.20ICEs.20.3F.20.2366530.html#183942222">(Dec 20 2019 at 14:58)</a>:</h4>
<p>(as noted <a href="https://github.com/rust-lang/rust/blob/6b561b4917e803c4be4ca44d8e552b680cb9e380/src/librustc_codegen_ssa/back/write.rs#L1579" target="_blank" title="https://github.com/rust-lang/rust/blob/6b561b4917e803c4be4ca44d8e552b680cb9e380/src/librustc_codegen_ssa/back/write.rs#L1579">here</a>)</p>



<a name="183942371"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/spawn_work%20turns%20FatalErrors%20into%20ICEs%20%3F%20%2366530/near/183942371" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/spawn_work.20turns.20FatalErrors.20into.20ICEs.20.3F.20.2366530.html#183942371">(Dec 20 2019 at 15:00)</a>:</h4>
<p>is there any reason I should not attempt to turn a <code>FatalError</code> in the worker thread into a corresponding <code>FatalError</code> on the conductor?</p>



<a name="183942440"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/spawn_work%20turns%20FatalErrors%20into%20ICEs%20%3F%20%2366530/near/183942440" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/spawn_work.20turns.20FatalErrors.20into.20ICEs.20.3F.20.2366530.html#183942440">(Dec 20 2019 at 15:00)</a>:</h4>
<p>(so that we get a clean shutdown instead of an ICE from the conductor?)</p>



<a name="183942605"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/spawn_work%20turns%20FatalErrors%20into%20ICEs%20%3F%20%2366530/near/183942605" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/spawn_work.20turns.20FatalErrors.20into.20ICEs.20.3F.20.2366530.html#183942605">(Dec 20 2019 at 15:02)</a>:</h4>
<p>Changing this sounds good to me</p>



<a name="183942929"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/spawn_work%20turns%20FatalErrors%20into%20ICEs%20%3F%20%2366530/near/183942929" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/spawn_work.20turns.20FatalErrors.20into.20ICEs.20.3F.20.2366530.html#183942929">(Dec 20 2019 at 15:05)</a>:</h4>
<p>next Q: is that a Major Change? <span aria-label="wink" class="emoji emoji-1f609" role="img" title="wink">:wink:</span></p>



<a name="183943044"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/spawn_work%20turns%20FatalErrors%20into%20ICEs%20%3F%20%2366530/near/183943044" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/spawn_work.20turns.20FatalErrors.20into.20ICEs.20.3F.20.2366530.html#183943044">(Dec 20 2019 at 15:06)</a>:</h4>
<p>:)</p>



<a name="183943063"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/spawn_work%20turns%20FatalErrors%20into%20ICEs%20%3F%20%2366530/near/183943063" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/spawn_work.20turns.20FatalErrors.20into.20ICEs.20.3F.20.2366530.html#183943063">(Dec 20 2019 at 15:07)</a>:</h4>
<p>no, bug fix</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>